If email messages are the (or a) mechanism your hosting provider gives you to make a pull request, this could work. The git request-pull command generates email messages. On that note, also remember that we all have different ways of approaching problems and different styles of coding. A pull request is a thing that GitHub, or Bitbucket, or some other web hosting service, provides. Shortly, we started to see memory issues as the datasets grew and the process started to fail.
#Git pr code#
However, this developer was so convinced that because his elegant code was perfect, that when the issue was brought up, he couldn't see past the technical correctness of his code for the real problem, so it went to production.
An alternative approach would have used a bulk transfer tool to stream the data between databases and minimize the memory overhead. Using a transactional ORM was basically an approach fraught with issues, as it needed to load each record into an object to transfer it. The problem was that this was a batch process that had to copy gigabytes of data from one database to another. For example, does it really matter that your variable names all adhere to a pattern if the code is too slow and frustrates a user? Further, I remember a time where a developer was so focussed on writing good code with an ORM, that they thought it was awesome. One thing I have learned over the years is that technical correctness and pedanticness do not necessarily equate to good code. I have found that these principles help the process go smoother no matter if you are the reviewer or the reviewee. I like to approach code reviews with some principles in mind.
Anyways, maybe through my pain and experiences you'll find something that helps. Surprisingly, this seems to be a set of skills that are not generally well developed in post-secondary computer science type programs (at least in my experience). I have done the Google searches, read leadership articles about it and most of all struggled through it myself. I have struggled with this over my near 20 years of programming, first in the form of code reviews, and now in the form of pull requests. No one likes to be criticized, but when there is something wrong in the code, it needs to be brought up. What should you expect? Or maybe it is time to do your first PR review on someone else's code. But then comes your first pull request (PR).
0 kommentar(er)
